Bug #248
KickIt Displaying Srevers Twice
| Status: | Resolved | Start: | 08/29/2008 | |
| Priority: | Normal | Due date: | ||
| Assigned to: | Jannik Hartung | % Done: | 100% |
|
| Category: | Web Panel | |||
| Target version: | 1.3.1 | |||
Description
Updated to 1.3, and it seems to be fine. Just a few random errors, but other than that, it functions.
KickIt, when enabled, and found a player on the server, it will go through and check. It will list it as Player Kicked, however, it will restart the check with a blue window, and list the server that the person got kicked from twice, and I guess not do a check on the last server.
It won't display the first server it checked, when nothing was found, and it won't display the last server.
Let me know if this makes sense.
Thanks!
Associated revisions
- Partial rewrote the kickit feature. Now: works with ip bans, checks all servers in parallel, admins have to wait now untill its finished. that means, they cant browse along anymore with the blue window.
- Fixed
#248- KickIt Displaying Srevers Twice (isn't possible anymore)
History
Updated by Recon _ 128 days ago
I've located where the blue dialog box comes up (thanks to Firebug & Notepad++).
Line 100 of includes/page_builder.php.
ShowBox('Kicking from server...', '<iframe id="srvkicker" frameborder="0" width="100%" src="pages/admin.kickit.php?steam='.$_SESSION["srvkick"]["steam"].'"></iframe>', 'blue', '', true);
I don't think that box is supposed to be there as one is already being displayed on includes/sb-callback.php line 1468.
$objResponse->addScript("ShowKickBox('".$steam."');");
Updated by Recon _ 128 days ago
It only happens if you press the OK button before it finishes checking.
On the green box the OK button is there before it finishes checking all the servers. On the blue box, it doesn't appear until it's finished checking.
When this resolved, I think the OK button should not appear until KickIt has finished checking all servers.
Updated by Brandon Ma 128 days ago
Hey Recon,
Thanks for the reply. Using 1.3 web stuff, I've been able to reproduce it. Let me know if this makes sense, and see if you can reproduce it yourself.
I have 7 servers, and if a add a ban through the panel, it will start searching. If it finds a player on let's say, the 2nd server, it will kick it and then the blue dialogue box will appear, and start searching once more. However, when the blue dialogue box DOES appear, it shows the last server the player was "kicked and banned" from, and then display it as the first two in the list (rather than all 1-7), and cut off the last server. It'll display seven servers, just not the proper ones. See if you can test it yourself, and reproduce it.
I've done it several times to myself, and same result.
Thanks man!
Updated by Jannik Hartung 127 days ago
- Category set to Web Panel
- Status changed from New to Resolved
- Assigned to set to Jannik Hartung
- Target version set to 1.3.1
- % Done changed from 0 to 100
Blue box will not appear anymore.