Bug #276
Imported Bans Not Banning/Doing Proper Checks
| Status: | Resolved | Start: | 09/08/2008 | |
| Priority: | Urgent | Due date: | ||
| Assigned to: | Jannik Hartung | % Done: | 100% |
|
| Category: | Web Panel | |||
| Target version: | 1.3.1 | |||
Description
Just got the fix from Peace Maker, but I have a lot of people on the imported list, however it's not keeping them off the servers.
These are just a couple of examples...
Did a check for the ID's in the sourcebans log file, and it brings up:
L 09/07/2008 - 12:44:05: [sourcebans.smx] Checking ban for: STEAM_0:0:19029098
L 09/07/2008 - 12:44:05: [sourcebans.smx] Checking ban for: STEAM_0:0:12345408
L 09/07/2008 - 12:44:05: [sourcebans.smx] STEAM_0:0:19029098 is NOT banned.
L 09/07/2008 - 12:44:05: [sourcebans.smx] STEAM_0:0:12345408 is NOT banned.
Anyway to fix this?
Associated revisions
- Fixed some search paginating problems
- Added page dropdown for logs
- Removed old code from admin.bans.php for importing...
- Fixed
#276- Imported Bans Not Banning/Doing Proper Checks - Added search for ban type (Steamid|IP)
History
Updated by Brandon Ma 119 days ago
I already got that fix, however its not keeping them off the servers after doing a fresh install of the trunk last night.
It doesnt even record the people being blocked. And gives the message about those people not being banned, when checked.
Any other options?
insomgaming.net/sourcebans
There were at least 10 people who came into the server, cause it was flagging them as "okay". As per the messages up above.
Let me know...
Updated by Erik Minekus 118 days ago
Might have to do with the duplicate code in admin.bans.php, lines 57 - 76.
Updated by Brandon Ma 118 days ago
Let me know if it can be fixed, and actually start blocking people. It somehow managed to block ONE person, and that was it.
Updated by Brandon Ma 118 days ago
Thanks Peace and Erik.
So, once you fix it and I update it again, it should be okay?
It should start blocking them again?
No need to reinstall it?
Updated by Jannik Hartung 118 days ago
- Category set to Web Panel
- Status changed from New to Resolved
- Assigned to set to Jannik Hartung
- Target version set to 1.3.1
- % Done changed from 0 to 100
UPDATE sb_bans SET ip = '' WHERE ip IS NULL AND name = 'Imported Ban' AND reason = 'banned_user.cfg import'; UPDATE sb_bans SET authid = '' WHERE authid IS NULL AND name = 'Imported Ban' AND reason = 'banned_ip.cfg import';
hopefully fixed in r147
Updated by Jannik Hartung 118 days ago
just run them in pma or similar;)
they set the `ip` field to '' instead of NULL if it was a banned_user.cfg file and the `authid` field to '' instead of NULL if it was a banned_ip.cfg file. so dont worry about your bans ;)
Updated by Brandon Ma 118 days ago
I'm kind of lost when it comes to this. I just uploaded the new web stuff, and cleared themes_c at this point.
Mind telling me what to do in phpmyadmin exactly?
I located the tables, and selectd the query tab, but completely lost after that.
thanks!
Updated by Jannik Hartung 118 days ago
just copy and paste the two queries into the sql field and execute them. maybe you have to edit the 'sb'_bans to 'mysb'_bans or whatever ;)
Updated by Brandon Ma 118 days ago
I got it, and then it returned this.
UPDATE sb_bans SET ip = '' WHERE ip IS NULL AND name = 'Imported Ban' AND reason = 'banned_user.cfg import';# MySQL returned an empty result set (i.e. zero rows).
UPDATE sb_bans SET authid = '' WHERE authid IS NULL AND name = 'Imported Ban' AND reason = 'banned_ip.cfg import';# MySQL returned an empty result set (i.e. zero rows).
So, all should be good and it'll start blocking people now?
Updated by Jannik Hartung 118 days ago
yes i think so. say if there are further problems, but let us move this conversation into the forum thread!