Bug #383

Perma ban broken from in game

Added by Recon _ 98 days ago. Updated 79 days ago.

Status:Resolved Start:09/29/2008
Priority:Immediate Due date:
Assigned to:- % Done:

100%
Category:Game Plugin
Target version:1.3.1

Description

I have confirmed with Tsunami that there is indeed a bug. I think it's pretty serious.

Admins with the e (unban) flag are unable to perma ban players.

I setup my system to use groups for everything, so it may be that GetUserFlagBits doesn't properly find inherited permissions from groups.

If GetUserFlagBits is working as I think it should, there is probably a bug in the logic somewhere.

sourcebans.smx (25.8 KB) Recon _, 10/03/2008 09:45 PM

sourcebans.sp (65.1 KB) Recon _, 10/03/2008 09:45 PM

addons.zip (44.7 KB) Recon _, 10/03/2008 09:52 PM

Associated revisions

Revision 170
Added by Erik Minekus 79 days ago

History

Updated by Erik Minekus 98 days ago

Well, you didn't have to post it as I already said I would look into it. But oh well.

Updated by Recon _ 98 days ago

Just so everyone knows that the team is aware of it. That way, people won't re-report it.

This might work.

new AdminId:admin = GetUserAdmin(client);
if (admin != INVALID_ADMIN_ID && GetAdminFlag(admin, Admin_Unban, Access_Effective))
   // Allow perma bans

Updated by Recon _ 94 days ago

I have patched the bug myself.

For easy of use, I included a zipped package of the game_upload folder with my patched version.

I ended up using this snippet of code
new AdminId:admin = GetUserAdmin(client);
new bool:hasUnban = (admin != INVALID_ADMIN_ID && GetAdminFlag(admin, Admin_Unban, Access_Effective));

Updated by Recon _ 94 days ago

Updated by Max Krivanek 88 days ago

Bug #376

That issue also shows a fix, though it was "Rejected" it was a valid bug. I simply opted to remove the code entirely as it just isn't needed for the community I am in.

Updated by Recon _ 87 days ago

The bug was rejected because they didn't understand that something was broken. It is. And the fix is here.

Updated by Erik Minekus 79 days ago

  • Status changed from New to Resolved
  • Target version set to 1.3.1
  • % Done changed from 0 to 100

Fixed in r170.

Also available in: Atom PDF