Bug #392

Admins with the Unban All flag cannot Unban all.

Added by Max Krivanek 96 days ago. Updated 91 days ago.

Status:Resolved Start:10/02/2008
Priority:Normal Due date:
Assigned to:- % Done:

100%
Category:Web Panel
Target version:1.3.1

Description

page.banlist.php Line 47
@ if (!$userbank->HasAccess(ADMIN_OWNER) &&
!($userbank->HasAccess(ADMIN_UNBAN_OWN_BANS) && $res->fields['aid'] $userbank->GetAid()) &&
!($userbank->HasAccess(ADMIN_UNBAN_GROUP_BANS) && $res->fields['gid'] $userbank->GetProperty('gid')))
die("You don't have access to this");@

There is no check in the unban if for the Unban All permission. This was fixed by adding it of course.

Replaced with:
@ if (!$userbank->HasAccess(ADMIN_OWNER|ADMIN_UNBAN) &&
!($userbank->HasAccess(ADMIN_UNBAN_OWN_BANS) && $res->fields['aid'] $userbank->GetAid()) &&
!($userbank->HasAccess(ADMIN_UNBAN_GROUP_BANS) && $res->fields['gid'] $userbank->GetProperty('gid')))
die("You don't have access to this");@

Associated revisions

Revision 169
Added by Jannik Hartung 91 days ago

  • Added search for ban length
  • Made advanced search public again
  • Added #110 - Selection box interface for mass unban/delete
  • Fixed #392 - Admins with the Unban All flag cannot unban all
  • Fixed #398 - Long unban reasons cause the log table to size beyond the viewable area
  • Fixed #395 - column size doesn't match on protest and submission page

History

Updated by Max Krivanek 96 days ago

The inline code format apparently didn't like the code with multiple line returns in it.

if (!$userbank->HasAccess(ADMIN_OWNER|ADMIN_UNBAN) &&

    !($userbank->HasAccess(ADMIN_UNBAN_OWN_BANS) && $res->fields['aid']  $userbank->GetAid()) &&

    !($userbank->HasAccess(ADMIN_UNBAN_GROUP_BANS) && $res->fields['gid']  $userbank->GetProperty('gid')))

    die("You don't have access to this");

Updated by Jannik Hartung 91 days ago

  • Category set to Web Panel
  • Target version set to 1.3.1
  • % Done changed from 0 to 100

thank you!

Updated by Jannik Hartung 91 days ago

  • Status changed from New to Resolved

Also available in: Atom PDF