Bug #81

SourceBans + Basebans = Menu ban item missing, sm_ban doesn't work (gives access error)

Added by Recon _ 206 days ago. Updated 168 days ago.

Status:Resolved Start:06/14/2008
Priority:Normal Due date:
Assigned to:Shane Froebel % Done:

100%
Category:Game Plugin
Target version:1.2.1 Estimated time:0.10 hours

Description

For some reason, if SourceBans and basebans are both in the plugins folder, even though SourceBans unloads basebans, it still seems to cause problems.

This problem doesn't happen right away, it usually happens after a few map changes.

I suggest that the below change be made to the plugin.

@public OnConfigsExecuted() {
decl String:filename200;
BuildPath(Path_SM, filename, sizeof(filename), "plugins/basebans.smx");
if(FileExists(filename)) {
//ServerCommand("sm plugins unload basebans"); // Problems still seem to happen
SetFailState("SourceBans failed to load, plugins/basebans.smx must be moved to plugins/disables/basebans.smx"); // Uncommented
}
}@

Associated revisions

Revision 98
Added by Erik Minekus 168 days ago

  • Added #156
  • Fixed #158
  • Fixed #161
  • Fixed #81
  • Fixed Unknown group error when not being part of a group
  • Fixed not getting any flags in admins.cfg when having one flag and not being part of a group
  • Fixed admins sometimes not being removed from admins.cfg
  • Fixed version number in plugin

History

Updated by Erik Minekus 205 days ago

Well that makes sense, seeing how basebans is reloaded the next map change. As far as I know it's clearly stated in the install guide that you should remove basebans, and if not, we should add that :)

Updated by Erik Minekus 200 days ago

  • Assigned to set to Shane Froebel
  • Target version set to 1.1.1

Updated by Olly Ginger 170 days ago

  • Target version changed from 1.1.1 to 1.2.1

Updated by Erik Minekus 168 days ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

Fixed in r98

Updated by Olly Ginger 168 days ago

  • Status changed from Closed to Resolved

If we are going to stop the plugin loading, we should add a message in the sourcebans.log file. If we simply unload it, people will not know whats going on.

At least (before this change) the majority of the plugin works.

Updated by Erik Minekus 168 days ago

I don't see what's wrong with SetFailState, it will report the error in the logs and in sm plugins list, so it should be obvious. More obvious than it was, because basebans is reloaded the next map, and people wonder why they have no ban menu, because we don't tell them anywhere that basebans should be disabled.

Also available in: Atom PDF